Skip to content

Rename ZEND_STR_DEPRECATED to ZEND_STR_DEPRECATED_CAPITALIZED #15831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 10, 2024
Merged

Rename ZEND_STR_DEPRECATED to ZEND_STR_DEPRECATED_CAPITALIZED #15831

merged 1 commit into from
Sep 10, 2024

Conversation

DanielEScherzer
Copy link
Member

To match other capitalized strings like ZEND_STR_UNKNOWN_CAPITALIZED and ZEND_STR_ARRAY_CAPITALIZED. Since this known string was only added in PHP 8.4, no backwards compatibility alias is needed.

@DanielEScherzer
Rename ZEND_STR_DEPRECATED to ZEND_STR_DEPRECATED_CAPITALIZED
418490c 
To match other capitalized strings like `ZEND_STR_UNKNOWN_CAPITALIZED` and
`ZEND_STR_ARRAY_CAPITALIZED`. Since this known string was only added in PHP
8.4, no backwards compatibility alias is needed.
@DanielEScherzer
Copy link
Member Author

Sent per suggestion on #15751 by @Girgias

@DanielEScherzer DanielEScherzer mentioned this pull request Sep 10, 2024
Merged
Girgias
Girgias approved these changes Sep 10, 2024
View reviewed changes
Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Girgias Girgias merged commit db54576 into php:master Sep 10, 2024
10 checks passed
@DanielEScherzer DanielEScherzer deleted the deprecated-constant branch September 10, 2024 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Girgias Girgias Girgias approved these changes

@dstogov dstogov Awaiting requested review from dstogov dstogov is a code owner

@nielsdos nielsdos Awaiting requested review from nielsdos nielsdos is a code owner

@bukka bukka Awaiting requested review from bukka bukka is a code owner

@TimWolla TimWolla Awaiting requested review from TimWolla TimWolla is a code owner

@zeriyoshi zeriyoshi Awaiting requested review from zeriyoshi zeriyoshi is a code owner

@devnexen devnexen Awaiting requested review from devnexen devnexen is a code owner

@NattyNarwhal NattyNarwhal Awaiting requested review from NattyNarwhal NattyNarwhal is a code owner

@derickr derickr Awaiting requested review from derickr derickr is a code owner

@kocsismate kocsismate Awaiting requested review from kocsismate kocsismate is a code owner

Assignees
No one assigned
Labels
Category: Build System Category: Engine Extension: date Extension: enchant Extension: hash Extension: intl Extension: libxml Extension: mysqli Extension: odbc Extension: openssl Extension: pgsql Extension: random Extension: reflection Extension: shmop Extension: spl Extension: standard Extension: xml Extension: zip
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DanielEScherzer @Girgias